loustler commented on PR #11648: URL: https://github.com/apache/seatunnel/pull/11648#issuecomment-5229160885
@DanielLeens opened as you asked: #11718, standalone against `dev`, flagged as blocking-adjacent to #11679 in the description. Your argument for standalone changed how I scoped it, so it's worth saying what it changed. Once the bound wasn't riding along with a shade bump, "what does this branch need to go green" stopped being the criterion and "what does `dev` need" took over — so it bounds every job submission in `PaimonWithS3IT` via an `executeJob` override rather than just the two calls in the privilege tests, and the deadline is derived from the measured green-run cost (~15 s per submission, bound set at 5 minutes) rather than picked to be comfortably under 180. Two things I chose to state in the PR rather than leave for review to find. `assertTimeoutPreemptively` abandons the worker thread instead of interrupting it, so a genuinely stuck exec stays parked until the JVM exits — the bound frees the test run and the runner slot, not the thread. And I could not run the IT locally: `testcontainer.version` is pinned at 1.17.6, whose docker-java negotiates Docker API 1.32, and the daemon I have requires 1.40+. Bumping the pin works but perturbs container startup timing, which is the exact variable this hang turns on, so I'd have been testing a different system. Compile and the compiled override are verified; the behaviour is on CI. This PR keeps its scope to the 3.4.3 migration, as you suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
