SEZ9 commented on PR #11648: URL: https://github.com/apache/seatunnel/pull/11648#issuecomment-5316847755
@loustler — summarizing where this stands after the latest pass. The current head `5793d1041c` is a catch-up merge from `dev` (tip `b1e21631ff`) with a single, correctly resolved import conflict and no net content change versus the previously approved `9ae57a54`. I re-verified the load-bearing files directly against the current head rather than assuming the merge carried everything forward, and my APPROVED review stands. One non-blocking item: the `Build` check on this head shows as cancelled solely because `jdbc-connectors-it-part-1 (8, ubuntu-latest)` hit its 120-minute job timeout. That job is unrelated to this PR's diff (no Hadoop/S3/AWS/OSS signature), and the JDK 11 sibling leg passed. A job-level rerun should turn the overall check green — worth doing before or right after merge so the CI record on this head is unambiguous, but I wouldn't hold merge on it. Ready to merge from my side. Thanks for the careful work across the review rounds. <!-- streview-comment:172 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
