DanielLeens commented on PR #11648: URL: https://github.com/apache/seatunnel/pull/11648#issuecomment-5279208210
Thanks @SEZ9 for the extra pass, and sorry that this slipped through my own rounds too. On the OssFile.md pairing: +1, and it's actually worse than the one line you spotted. `seatunnel-connectors-v2/connector-file/connector-file-oss/pom.xml` now pins `hadoop-aliyun.version=3.4.3` (inherited from the root pom, lockstep with `hadoop3.version`) and bumps `aliyun-sdk-oss` from 3.4.1 to 3.13.2 and `jdom` 1.1 to `jdom2` 2.0.6.1 - the pom's own new comment spells out why the old pairing breaks: `aliyun-sdk-oss` 3.4.1 is missing the `ListObjectsV2Request/Result` types and four `OSSClient` methods return `void` instead of `VoidResult`, so "every OSS listing would therefore fail at runtime with nothing failing at build time." All four doc variants (`docs/en|zh/connectors/sink|source/OssFile.md`) still tell users to grab `hadoop-aliyun-3.1.4.jar`, `aliyun-sdk-oss-3.4.1.jar` and `jdom-1.1.jar` next to the new `seatunnel-hadoop3-3.4.3-uber.jar` - that's a doc bug that reproduces the exact silent-runtime-failure scenario the pom comment warns about. This should block merge until f ixed. On the S3File.md `getInstance()` point: I checked this one against Hadoop 3.4.3 source and I don't think it's stale. `CredentialProviderListFactory.createAWSCredentialProviderList()` tries the v2 path first (`AwsV1BindingSupport`-free, method name `create`, interface `AwsCredentialsProvider`), and only on `IsNotImplementation` falls back to `AwsV1BindingSupport.createAWSV1CredentialProvider` -> `V1ToV2AwsCredentialProviderAdapter.create(conf, className, uri)`, which literally does `S3AUtils.getInstanceFromReflection(className, conf, uri, AWSCredentialsProvider.class, "getInstance", ...)`. So the doc's fourth mechanism is real, it's just gated on `isAwsV1SdkAvailable()` - which, post this PR's shaded-jar migration, won't be true unless the user separately adds a v1 SDK jar. Worth a one-line caveat in the doc, but not a v1/v2 naming bug. Given the OssFile.md issue, walking back my "Ready to merge" - please pin the correct `hadoop-aliyun`/`aliyun-sdk-oss`/`jdom2` versions in all four OssFile.md files before this goes in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
