SEZ9 commented on PR #11727: URL: https://github.com/apache/seatunnel/pull/11727#issuecomment-5381239640
Thanks @abdessalems, and thanks @davidzollo for the +1. To recap: my from-scratch re-review of the current head (`72268def`) found no blockers — the core fix (lookup moved inside `try`, explicit `IllegalStateException` instead of the implicit NPE, `startLatchReleased`-guarded latch release in `finally`) and the null guards on the racy `executionContexts` reads in `taskDone()` and `recycleClassLoader()` are all in the shape I reviewed at `45a6d3bf7`, plus the `TaskDeployStaleContextRaceTest` covering the stale-generation race. Since we agree this stays as the main PR, I'll close the duplicate as superseded. Remaining before merge: let CI finish on the fresh base you pushed after merging latest dev. If anything fails, ping here or the #contributors Slack channel davidzollo linked; otherwise no further code changes are needed from my side. Once CI is green this is good to merge. Thanks for the persistence, @abdessalems — turning a silent client hang into a loud, bounded failure is a real quality-of-life win. <!-- streview-comment:456 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
