li3zhi4 commented on PR #11746:
URL: https://github.com/apache/seatunnel/pull/11746#issuecomment-5262846913
Thank you for pointing this out. You're absolutely correct — the default
value of supportCompositeKeySplit() should be false, as most JDBC dialects do
not support row-value-constructor comparison syntax. I will fix this in my next
commit and also add explicit support for multiple databases that do support
this feature.
At 2026-08-12 11:58:12, "panda" ***@***.***> wrote:
@LeonYoah commented on this pull request.
In
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/JdbcDialect.java:
> @@ -364,6 +364,29 @@ default boolean supportStringRangeSplit() {
return false;
}
+ /**
+ * Returns whether this dialect supports row-value-constructor
comparison syntax used by
+ * composite-primary-key chunk splitting, i.e. ***@***.*** (col1, col2)
> (?, ?)}.
+ *
+ * <p>MySQL, PostgreSQL (and its derivatives) and SQLite support
row-value comparisons; SQL
+ * Server (T-SQL) and several other dialects do not and would fail with
a syntax error if such
+ * predicates were emitted. The splitter falls back to the
single-column behavior when this
+ * returns ***@***.*** false}.
+ */
+ default boolean supportCompositeKeySplit() {
+ return true;
Shouldn't the default be false?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
