li3zhi4 commented on code in PR #11746:
URL: https://github.com/apache/seatunnel/pull/11746#discussion_r3766020934
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/JdbcDialect.java:
##########
@@ -364,6 +364,29 @@ default boolean supportStringRangeSplit() {
return false;
}
+ /**
+ * Returns whether this dialect supports row-value-constructor comparison
syntax used by
+ * composite-primary-key chunk splitting, i.e. {@code (col1, col2) > (?,
?)}.
+ *
+ * <p>MySQL, PostgreSQL (and its derivatives) and SQLite support row-value
comparisons; SQL
+ * Server (T-SQL) and several other dialects do not and would fail with a
syntax error if such
+ * predicates were emitted. The splitter falls back to the single-column
behavior when this
+ * returns {@code false}.
+ */
+ default boolean supportCompositeKeySplit() {
+ return true;
Review Comment:
You are right - fixed in the latest commits. supportCompositeKeySplit() now
defaults to false, and only the dialects whose composite-PK path is validated
by an official E2E (MySQL, PostgreSQL, SQLite, SQL Server, Oracle) override it
to true. Each override documents its validating E2E class; unvalidated dialects
keep the single-column fallback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
