li3zhi4 commented on PR #11746: URL: https://github.com/apache/seatunnel/pull/11746#issuecomment-5289299370
Thanks for the thorough review. As recommended, I've **reverted the lazy/streaming split-generation commit** (`4a9330439` → `7f4980622`) — the current PR no longer contains that feature, and it will be tracked as a separate follow-up (own PR) rather than bundled here. Both new High issues are therefore resolved by removal (no `enable_concurrent_read=false` bypass, no duplicated boundary-walk logic in this PR). The other items from this round are also addressed: - **Issue 3** (missing split-count log in the streaming branch): moot — the streaming branch is gone with the revert; - **Issue 4** (docs not naming the opted-in dialects): fixed in `bf4ff5a3` — the docs now list MySQL/PostgreSQL/SQLite/SQL Server/Oracle as the dialects with `supportCompositeKeySplit()=true`. On CI: the failing `JdbcOracleSplitIT` (Docker 404 for `gvenzl/oracle-xe:21-slim-faststart`) matches the Testcontainers image-pull race you identified; I'll re-run the failed jobs to confirm green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
