wybaby168 commented on PR #11770:
URL: https://github.com/apache/seatunnel/pull/11770#issuecomment-5267792745
Thanks for the thorough lifecycle review and for calling out the over-broad
failure-path discard.
I applied Option A in 7f70804263e41ccc190ac29cf9a7fb1bcf7b6f6e:
- cleanupAfterOpenFailure() now discards the cached connection only when
statement creation failed before assignment, or when cleanup cannot restore
a known-safe connection state.
- An executeQuery() failure now closes the statement, rolls back the read
transaction, restores the configured auto-commit mode, and preserves the
connection when cleanup succeeds.
- Added a two-split regression test to verify that the same Connection
remains
reusable across successful split lifecycles.
- Updated the execute-failure regression to assert connection reuse instead
of
unconditional discard.
- Rebased onto the latest apache/seatunnel:dev and kept the branch as one
clean
commit.
Thank you again for the detailed review. Could you please take another look
when convenient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
