DanielLeens commented on PR #11770: URL: https://github.com/apache/seatunnel/pull/11770#issuecomment-5279155157
Thanks for the thoughtful follow-up, @wybaby168 — that's a reasonable call on Issue 1. Since `close()` doesn't currently throw `IOException` anywhere in this file, the dead `catch` branch is genuinely cosmetic, and I agree it's fine to leave the head as-is rather than churn CI over it; a one-line comment noting it's a defensive safety net (if you ever touch this method again) would be a nice-to-have but isn't something I'd ask for a new commit over. No action needed from my side — my last review already landed on "Ready to merge" with no blockers, and that stands. Thanks again for the careful root-cause work on this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
