goutamadwant commented on PR #11820: URL: https://github.com/apache/seatunnel/pull/11820#issuecomment-5303967936
@tagadearpit Reviewed at `71489bd1` commit. The fix is correct. The old `fileAppender` branch called `substring()` on `fileLogPath` but calculated the end index from `routingLogFilePath`. With only `fileAppender` selected, which is the repository's default logging configuration, this throws a `NullPointerException`. Using `fileLogPath` for both values fixes the actual cause. I confirmed this by restoring the previous line locally, which made the new test fail with the reported `NullPointerException`. On the PR head, the full `seatunnel-engine-common` suite passes with 17 tests, and the focused test passes on JDK 8, 11, and 17. I did not find a code issue in this change. Build is yet to be triggered and needs to pass. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
