tagadearpit commented on PR #11820: URL: https://github.com/apache/seatunnel/pull/11820#issuecomment-5308056701
Thanks @DanielLeens, @goutamadwant, and @davidzollo for the careful review and for independently confirming the correctness of the variable swap. The CI gate is understood. The fork’s Build check is currently `action_required` because workflows have not run there yet. I will enable GitHub Actions for `tagadearpit/seatunnel` and trigger a fresh run before requesting merge. Regarding the additional coverage, I agree that the silent wrong-directory case is the most valuable follow-up. This PR intentionally stays limited to the one-line production correction and the fileAppender-only regression that reproduces the reported NPE. A small package-private path-resolution seam with focused cases for the null, silent-truncation, overlong-index, routing-appender, and unknown-reference paths would make that broader coverage reliable; I will keep that as a follow-up unless maintainers prefer it in this PR. I also appreciate the note about the test fixture’s module-wide logging effect. I will preserve console diagnostics when expanding the fixture, and the fixed temporary filename and separator/`-1` handling concerns are noted as separate cleanup items rather than folded into this narrowly scoped bugfix. No documentation update is needed for this internal correction. Thanks again for the positive review and for pointing out the remaining verification and coverage work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
