zhang-arvin commented on PR #11864: URL: https://github.com/apache/seatunnel/pull/11864#issuecomment-5353117792
Thanks for the thorough review, @DanielLeens! All three issues have been addressed in the latest commit: **Issue 1 (debug log):** Added `log.debug` in `shouldEmit` showing the position vs `splitStartWatermark` for the non-exactly-once boundary check path. **Issue 2 (error enrichment):** `RuntimeException` in `PostgresWalFetchTask.execute` now includes the split ID and last committed LSN. **Issue 3 (tests):** Added: - `LsnOffsetTest`: `testGetLsnCommitWhenLsnCommitKeyExists` (returns `lsn_commit`) and `testGetLsnCommitFallbackToLsnWhenLsnCommitKeyMissing` (falls back to `lsn`) - `IncrementalSourceStreamFetcherTest`: `testShouldEmitAtOrAfterWatermark` (record at boundary IS emitted) and `testShouldEmitBeforeWatermarkFiltered` (record before boundary IS filtered) Also fixed the style nit — `LsnOffset.getLsnCommit()` now uses `import io.debezium.connector.postgresql.PostgresOffsetContext` instead of the fully-qualified inline reference. All existing tests pass. PTAL! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
