zhang-arvin commented on PR #11864: URL: https://github.com/apache/seatunnel/pull/11864#issuecomment-5380281127
@DanielLeens Thanks for the thorough review! Both issues addressed: 1. **Issue 1 (volatile)**: Marked `lastCommitLsn` as `volatile` to ensure cross-thread visibility. 2. **Issue 2 (unsynchronized mutation)**: Removed the `offset.getOffset().put(...)` in-place mutation entirely. The fallback in `getLsnCommit()` already handles the case when `LAST_COMMIT_LSN_KEY` is absent, so this edge-case optimization is not needed and was introducing unnecessary cross-thread mutation risk. Pushed as commit `7f5029c`. The CI rerun should also clarify the E2E test status. Happy to take another look! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
