SEZ9 commented on PR #11837: URL: https://github.com/apache/seatunnel/pull/11837#issuecomment-5358314552
Thanks everyone for the thorough follow-through here. @DanielLeens — much appreciated for the detailed re-review confirming that the current head `83403fce36c5` is content-identical to the previously verified `e803a00679f` (rebase-only change), and for the end-to-end re-trace of the routing path confirming the comment-event fixes don't leave the other ALTER COLUMN event types on a latent routing bug. Also thanks for the CI follow-up: with the `Build` check now reporting SUCCESS for this exact head, the last blocker you flagged is resolved. @CloverDew — thanks for re-triggering CI as @nzw921rx asked, and for the patience across all four rounds. The table-identifier normalization, the STRING `columnLength` relaxation with the `sourceType` fallback, and the dispatcher handling for comment events are all covered and verified per the reviews above. With @davidzollo's approval and @DanielLeens's updated approval both in, I see no remaining asks on the code side. From my end this is ready to merge — I'll proceed once I've done a final pass. Thanks again for the contribution, @CloverDew! <!-- streview-comment:403 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
