DanielLeens commented on PR #11841:
URL: https://github.com/apache/seatunnel/pull/11841#issuecomment-5363678745
Thanks @SEZ9 — good summary, and answers to both:
**1. Keeping the legacy `isStartWithSavePoint` wire argument as-is,
deprecation as a follow-up:** yes, I'm comfortable with that. That's exactly
what my Compatibility Impact section (1.2) concluded — `SubmitJobOperation`'s
wire format is untouched, the legacy field is still written and read on both
sides, and for every currently-reachable payload (old-format and new) that
field and the derived `RestoreMode` already agree, so nothing about deprecating
it is forced by this PR's own correctness. Rolling-upgrade safety during a
mixed old/new deploy needs that field to keep existing on the wire regardless,
so bundling a deprecation into this PR would only add risk to what's otherwise
a clean, additive refactor. A separate follow-up (once every reader of the
field has migrated to the `RestoreMode`-derived accessors, which this PR gets
us most of the way to) is the right place for that.
**2. The review body isn't actually cut off** — I just re-pulled it from the
API to double-check rather than assume: it's the full ~19k characters, all
three code fences are balanced, and it ends with the closing paragraph ("...I'm
comfortable with this going to a maintainer merge decision; the remaining
follow-up items above don't need to gate this PR."), Issue Summary table and
Merge Recommendation both present. If it rendered truncated in your view,
that's most likely a client/markdown-rendering hiccup on the
`CoordinatorService.java` before/after code block rather than a genuinely
missing observation on my end — I don't have anything further to add there
beyond what's already written in section 1.1.
No new blockers from me; my 2026-08-17 approval stands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
