JeremyXin commented on code in PR #11841:
URL: https://github.com/apache/seatunnel/pull/11841#discussion_r3922853973
##########
seatunnel-engine/seatunnel-engine-core/src/main/java/org/apache/seatunnel/engine/core/job/JobImmutableInformation.java:
##########
@@ -167,6 +168,14 @@ public boolean isRestoreJob() {
return restoreMode != null && restoreMode.isRestore();
}
+ public boolean isSavepointRestore() {
Review Comment:
Thanks for review! My understanding is that `JobImmutableInformation` is
mainly serialized as the job submission payload and sent to the master via RPC.
It is not part of the savepoint/checkpoint state itself, the restored job is
not deserializing `JobImmutableInformation` from savepoint storage？
Also, backward compatibility is already handled in the `writeData()` /
`readData()` logic of `JobImmutableInformation`.
If `restoreMode` is not explicitly written in an older payload, `readData()`
falls back to the legacy `isStartWithSavePoint` field and rebuilds the
restore-related semantics from there. So after deserialization, those fields
are still populated consistently instead of being left empty or defaulting
incorrectly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
