nzw921rx commented on code in PR #11841:
URL: https://github.com/apache/seatunnel/pull/11841#discussion_r3920593760


##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/CoordinatorService.java:
##########
@@ -1394,9 +1396,12 @@ public PassiveCompletableFuture<Void> submitJob(
                     try {
                         JobImmutableInformation 
submittedJobImmutableInformation =
                                 
deserializeJobImmutableInformation(jobImmutableInformation);
+                        boolean isSavepointRestore =

Review Comment:
   @DanielLeens I think the title of this PR is' Unified Processing ', should 
we provide me with a complete processing plan in this PR? Instead of putting it 
in the subsequent PR



##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/master/JobMaster.java:
##########
@@ -284,7 +285,7 @@ public synchronized void init(long initializationTimestamp, 
boolean restart) thr
                                                             sink.getId()));
                                     JobMaster.handleSaveMode(
                                             ((SinkAction<?, ?, ?, ?>) 
sink).getSink(),
-                                            logicalDag.isStartWithSavePoint());

Review Comment:
   @DanielLeens I think the title of this PR is' Unified Processing ', should 
we provide me with a complete processing plan in this PR? Instead of putting it 
in the subsequent PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to