SEZ9 commented on PR #10988: URL: https://github.com/apache/seatunnel/pull/10988#issuecomment-5381237724
Thanks @DanielLeens — agreed, let's treat your consolidated list as the single source of truth for the fix commit. - **Merge blocker (unresolved):** `PostgresTypeConverter.convert()` still sets `builder.sourceType(PG_VECTOR)` to the bare literal instead of baking the dimension in as `vector(N)`. Since `PostgresCreateTableSqlBuilder.buildColumnSql()` uses `column.getSourceType()` verbatim when source and sink share the same catalog identifier, the Postgres→Postgres auto-create-sink path (`JdbcPostgresPgVectorIT#testPgVectorAutoCreateSink`) keeps losing the dimension until this lands. - **Non-blocking, same commit:** pgvector docs/type mapping, guarding the bare `Integer.parseInt` on the dimension string, importing `ByteBuffer` instead of using the fully-qualified name, hardening/commenting the regex FROM-clause fallback (and dropping the stray backtick from the character class), and filling in the PR description/checklist placeholders. - **CI note:** thanks for the correction — head `8dcf4f646440` is `ahead_by=12, behind_by=42` against `dev`, not `behind_by=5`. Recommendation unchanged: sync with the latest `dev` first, then rerun `Build` (https://github.com/apache/seatunnel/runs/90634507052 is currently failing). Once the sourceType-dimension fix plus the items above land in one commit on a `dev`-synced head, ping us and I'll do a full re-review. <!-- streview-comment:450 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
