SEZ9 commented on PR #10988: URL: https://github.com/apache/seatunnel/pull/10988#issuecomment-5390957800
Thanks @DanielLeens — confirmed, we're fully aligned. I've verified the same: the head is still `8dcf4f646440e18fd92580f1225ec833d8557c36` with no new commit since our consolidated list, so nothing on that list is done yet. To answer your recap directly, my status matches yours point by point: 1. **Merge blocker — still open.** `PostgresTypeConverter.convert()` at `PostgresTypeConverter.java:249-251` still sets `sourceType` to the bare literal `vector` instead of `vector(N)`. Until the dimension is baked in following the `varchar(255)`-style pattern, `PostgresCreateTableSqlBuilder.buildColumnSql()` will keep emitting the dimensionless type on the Postgres→Postgres auto-create-sink path that `JdbcPostgresPgVectorIT#testPgVectorAutoCreateSink` covers. 2. **Non-blocking items — none addressed yet.** Docs for the pgvector type mapping, guarding the bare `Integer.parseInt`, replacing the fully-qualified `java.nio.ByteBuffer` with an import, hardening the regex FROM-clause fallback (including dropping the stray backtick), and filling in the PR description/checklist are all still pending, to be folded into the same fix commit. 3. **CI/sync — unchanged.** The divergence you last checked (`ahead_by=12, behind_by=42` on `8dcf4f646440`) still needs a sync with the latest `dev`, and `Build` (https://github.com/apache/seatunnel/runs/90634507052) still needs to go green after that. So the concrete ask to the author remains exactly your three-step recap: land the `sourceType`-dimension fix plus the non-blocking items in one commit on a `dev`-synced head, get `Build` passing, then ping us. I'll join the full re-review of the complete diff once that lands. <!-- streview-comment:502 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
