DanielLeens commented on PR #10988: URL: https://github.com/apache/seatunnel/pull/10988#issuecomment-5385671499
Thanks @SEZ9, confirmed we're aligned on the consolidated list as the single source of truth. I just re-checked live and the head is still unchanged at `8dcf4f646440e18fd92580f1225ec833d8557c36`, so the `sourceType`-dimension fix in `PostgresTypeConverter.convert()` is still the open blocker — no new commit has landed yet. @CosmosNi, to recap what's needed in one pass: 1. Bake the dimension into `sourceType` (`vector(N)`) in `PostgresTypeConverter.convert()` around `PostgresTypeConverter.java:249-251`, matching the `varchar(255)`-style pattern already used for other parameterized types in that file. 2. Fold in the non-blocking items from the consolidated list (docs, `Integer.parseInt` guarding, the `ByteBuffer` import, hardening the regex FROM-clause fallback, and filling in the PR description/checklist). 3. Sync with the latest `dev` (last checked as `ahead_by=12, behind_by=42`) and get `Build` green. Once that lands on a synced head, ping us and I'll do a full re-review of the complete diff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
