SEZ9 commented on issue #11878:
URL: https://github.com/apache/seatunnel/issues/11878#issuecomment-5385644972
@luozihen Thanks for the concrete examples — this is exactly the kind of
option shape plus precedence/fallback illustration that was asked for, and the
overall direction looks good.
A few points before moving to a PR:
1. **Example 2 looks truncated** — the expected behavior is described, but
the sink config is cut off. Could you post the full `multi-table_config` for
Example 2? It's the more interesting case since it mixes tables that get
`DATA_SOURCE` with one that doesn't, so it would demonstrate the
partial-override and fallback path.
2. **Regex matching semantics** — since the keys are patterns, please state
explicitly what happens when a table matches multiple patterns and when a table
matches none (presumably falling back to the existing `primary_keys` logic, per
your precedence proposal — just restate it alongside the examples).
3. **Placeholder usage** — Example 1 mixes `${primary_key}` with a concrete
field name. Since today placeholder expansion only supports `${primary_key}` as
the sole element, I'd suggest defining that expansion semantics inside
`multi-table_config` only, keeping the legacy `primary_keys` contract
untouched. That also answers your earlier question about mixed placeholder
usage: handle it in the new option rather than changing the old one.
4. Please also cover the interaction with generated SQL and auto-created
tables, and plan for docs in both English and Chinese.
Once those are nailed down here, I think this is ready for a focused PR.
Thanks again for driving this.
<!-- streview-comment:475 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
