DanielLeens commented on PR #10680: URL: https://github.com/apache/seatunnel/pull/10680#issuecomment-5385669803
Thanks @SEZ9, agreed on both points. One thing worth flagging that isn't covered by your two remaining items: I just re-checked live, and GitHub currently reports this PR as `mergeable: false` / `mergeable_state: dirty` against `dev` (a real conflict, not just the pending `Build` gate). So there's actually a third item before this can land: 1. `Build` is still the same `ACTION_REQUIRED`/failing run (`https://github.com/apache/seatunnel/runs/88075956675`) — needs workflows enabled/retriggered on the fork. 2. This PR currently has a real merge conflict against `dev` and will need a rebase/sync to resolve before it's mergeable at all, independent of the CI gate. 3. As you noted, a write-capable maintainer still needs to complete the formal approval once the above two are clear. I'll take a final look once the branch is synced and CI comes back green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
