SEZ9 commented on PR #10680: URL: https://github.com/apache/seatunnel/pull/10680#issuecomment-5390957402
Thanks @DanielLeens for the live re-check and for flagging the merge state — you're right that the conflict against `dev` is a separate blocker from the CI gate, so let's treat it as three items: 1. **Merge conflict**: not resolved yet. Since you pushed `0570563e5b` to the branch and know the label-state changes best, could you rebase/sync the branch onto `dev` and push? That keeps the conflict resolution consistent with your test coverage. 2. **CI**: the `Build` run (https://github.com/apache/seatunnel/runs/88075956675) is still the same `ACTION_REQUIRED` state. Once the rebase lands, I'll make sure the workflows are approved/retriggered on our side so we get a fresh run against the synced head. 3. **Formal approval**: agreed — since your `COMMENTED` review records the technical conclusion but doesn't satisfy the approval gate, I'll complete the write-capable review once the branch is synced and `Build` comes back green. So the concrete remaining ask from me is just the rebase against `dev`; after that push, ping this thread and I'll handle the CI retrigger and final approval. Thanks again for carrying this data-loss fix through — the VISIBLE/COMMITTED/ABORTED/UNKNOWN coverage you added is exactly what we want guarding this path. <!-- streview-comment:500 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
