DanielLeens commented on PR #11943: URL: https://github.com/apache/seatunnel/pull/11943#issuecomment-5390008534
Good question, @KaustAbhinand — let me separate the two parts. On CI: the failure you're seeing is just the standard first-time-contributor gate — a maintainer (or you, on your own fork) needs to approve/enable Actions before the workflow can run for real, same as @davidzollo's comment above pointed out. It's not a test failure, and since your PR contains zero file changes there's nothing in the codebase that could fail a build or test anyway. No code-side fix needed there. On "is this considered completed": from a code-review standpoint, yes — I independently re-checked every file under `connector-google-sheets/src/main/java` and confirmed your audit finding is correct: there's no imperative `if/throw` config-validation logic left to migrate for #11007 (the one `if` in `SheetsSourceReader` is a runtime null-check on the Sheets API response, not config validation, so it's out of scope by design). But since the PR itself has no diff, there's nothing for `dev` to merge — an empty commit would land in history without documenting anything durable. My recommendation is to treat this as the deliverable being the audit result, not a mergeable PR: best next step is to post this finding directly on the #11007 tracking issue (marking `connector-google-sheets` as reviewed/no-migration-needed) and close this PR rather than merge it. That's ultimately a maintainer call, but from a "what does this PR add to the repo" perspective, that's the cleaner path. Thanks again for doing the audit legwork — it's genuinely useful for keeping the tracker accurate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
