DanielLeens commented on PR #11943: URL: https://github.com/apache/seatunnel/pull/11943#issuecomment-5396344072
Thanks for the pointer, @KaustAbhinand — I went and read the summary you posted on #11007, and also re-checked it against the full file list under `connector-google-sheets/src/main/java` (config, deserialize, exception, source packages) to make sure nothing was missed. Your list matches exactly what's in the module: - `SheetsParameters`, `SheetsSourceOptions` (config) - `SheetsSource`, `SheetsSourceFactory`, `SheetsSourceReader` (source) - `GoogleSheetsDeserializer`, `SeaTunnelRowDeserializer` (deserialize) - the exception classes I additionally opened `GoogleSheetsDeserializer` specifically since it wasn't in my first pass — it only wraps `IOException`/`JsonProcessingException` from row deserialization into `GoogleSheetsError`/`CommonError`, which is runtime error translation, not config `if/throw` validation, so it's correctly out of scope for #11007 too. So to confirm: your audit is complete and accurate, `connector-google-sheets` genuinely has nothing to migrate. My earlier recommendation still stands as the cleanest path forward — since this PR itself has no code diff, I'd suggest closing it and letting the finding live on the #11007 tracking issue (which you've now updated) rather than merging an empty commit into `dev`. That's a maintainer call to finalize, but from a review standpoint there's nothing left blocking here. Thanks for being thorough about it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
