davidzollo commented on PR #11503: URL: https://github.com/apache/seatunnel/pull/11503#issuecomment-5433521363
Thanks for the thorough re-verification and the approval, @DanielLeens. Handoff summary at head `1e5493c9f8`: - **Blockers: none.** The 2026-08-24 NPE blocker is fixed and regression-covered; the fix and the `RestoreTableSchemaEvent` contract Javadoc were both independently re-verified in the approval above. - **CI:** run [32970480584](https://github.com/nielifeng/seatunnel/actions/runs/32970480584) — 76 green, and the only 3 non-green jobs are classified infra issues unrelated to this diff (Maven Central connection reset on `testcontainers:databend`; the known `CouchbaseIT` container-bootstrap flake; a `timeout-minutes: 120` budget cancellation mid-passing-tests), a classification the approval above re-confirmed independently. @nielifeng — the one-click **"Re-run failed jobs"** ask from [my earlier comment](https://github.com/apache/seatunnel/pull/11503#issuecomment-5431021868) still stands; fork Actions reruns need repo admin, so it has to come from your side. - **@SEZ9** — the precondition from your 2026-08-25 note is now met: the NPE details were posted and the defect is fixed on the current head, and each of PR11503-F1..F8 has either a landed fix or an explicit rationale in the [disposition table](https://github.com/apache/seatunnel/pull/11503#issuecomment-5425538451) (F1/F3/F7/F8 fixed and independently verified; F5 rebutted with the per-table equality gate; F2 contract now documented on the event class; F4 synchronized with wholesale-replace rationale; F6 rationale: no table identity exists in the dispatchers' `reset(...)` context to compare against). Requesting your full re-review pass to resolve the standing CHANGES_REQUESTED. - **Non-blocking follow-ups on record** (from the approval): SPI-wide enforcement for the restore-means-no-DDL rule, dispatch-shortcut identity assertion, a thread-ordering comment on `pendingRestoreTables`, and a dedicated failover-then-restore IT. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
