DanielLeens commented on issue #11846:
URL: https://github.com/apache/seatunnel/issues/11846#issuecomment-5453918735

   Thanks for opening `#11991`.
   
   I rechecked current `dev` at `1ff72ceb3d2a823a0fca64ec009984d75e846c28`. The 
earlier non-blocking readiness guards from `#10841` are already on the branch, 
but the narrower race you are fixing is still real: a collector can pass the 
readiness check and then hit `getCoordinatorService()` after coordinator state 
changes, which still turns the scrape into a `/metrics` failure window.
   
   So `#11991` is the right follow-up scope for the remaining gap. The merge 
bar here should stay narrow:
   1. return empty samples only for this transient coordinator-startup race;
   2. keep unexpected exceptions visible instead of masking unrelated bugs;
   3. keep the regression coverage focused on the collectors that still cross 
this path.
   
   Once the branch is green, this issue will be much closer to closure.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to