kuswardhanietidims-svg commented on PR #11997: URL: https://github.com/apache/seatunnel/pull/11997#issuecomment-5466608668
Thanks for the third-pass review and for verifying `9be70636c` against each affected file rather than taking the changelog summary at face value — the diff-level confirmation is appreciated. Agreed on all three items: `ORCAROUTER_ECHO_REASONING_CONTENT` now has full env-var parity with `OPENAI_ECHO_REASONING_CONTENT` via the shared `_env_bool()` helper, the redundant `if not os.environ.get(...)` guards are collapsed to bare `setdefault` calls matching the rest of `create_provider()`, and the test temp-dir leak is fixed. The new test covers explicit `false`/`true` plus the unset-default path. No further changes are planned on this branch. The PR is ready for the formal approval whenever a maintainer with write access can submit it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
