SEZ9 commented on PR #11997: URL: https://github.com/apache/seatunnel/pull/11997#issuecomment-5469330291
Thanks @DanielLeens for the thorough re-verification — diffing `4a576f78e..9be70636c` directly rather than relying on the description is exactly the kind of confirmation that helps here. Good to see Issues 1–3 closed, and the new `ORCAROUTER_ECHO_REASONING_CONTENT` env var plus the `test_echo_reasoning_content_env_override` test is a clean resolution for the reasoning-replay toggle. That said, the new commit also partially unblocks two of my earlier documentation findings, and a few asks from my previous round remain open. Concretely: 1. **Reasoning-content docs (F7/F8):** now that `ORCAROUTER_ECHO_REASONING_CONTENT` exists in `9be70636c`, please document it in `seatunnel-cli/README.md` and `docs/en/ai-cli/quickstart.md`, and clarify whether `OPENAI_ECHO_REASONING_CONTENT` has any effect when `AI_PROVIDER=orcarouter`. 2. **Base-URL scoping (F1/F5):** please document how an already-exported `OPENAI_BASE_URL` interacts with the OrcaRouter provider, and either add an `ORCAROUTER_BASE_URL` override in `seatunnel-cli/env.example.sh` or state explicitly that the gateway endpoint is fixed. Requests carrying `ORCAROUTER_API_KEY` must not be redirectable to an arbitrary host via the inherited OpenAI var. 3. **Fail-fast behavior (F2):** a missing `openai` package or a missing/empty `ORCAROUTER_API_KEY` should raise an orcarouter-specific error in `seatunnel-cli/seatunnel_cli/cli.py` instead of surfacing OpenAI-oriented messages at runtime. 4. **Data-handling caveat for `orcarouter/auto` (F3):** since prompts routinely contain database credentials and the default model routes dynamically to unspecified downstream vendors, `docs/en/ai-cli/quickstart.md` needs an explicit caveat. 5. **Model fallback semantics (F4):** document the precedence between `ORCAROUTER_MODEL` / `ORCAROUTER_SMALL_FAST_MODEL`, the inherited `OPENAI_MODEL` vars, and the config-file override path in `seatunnel-cli/README.md`. 6. **Provider selection with multiple credentials (F6):** document which provider wins when several API keys are exported, so users aren't silently switched to orcarouter. None of these require code churn beyond items 2–3; the rest are documentation additions. Happy to take another look once those land. <!-- streview-comment:683 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
