DanielLeens commented on PR #11951: URL: https://github.com/apache/seatunnel/pull/11951#issuecomment-5488585964
CI follow-up on my review above: I flagged the apache-side `Build` check as `FAILURE` and traced it to a set of pre-existing, unrelated flakes (`CoordinatorServiceTest` Awaitility timing in engine, `PythonSourceTest`, a Couchbase testcontainer bootstrap issue, and a cascaded `rocketmq-connector-it` cancellation) — none touching `seatunnel-transforms-v2` or `StringFunction`. Re-checked live: the head is unchanged, and the `Build` check (run `98840719989`) now shows `pass`, along with `Notify test workflow` and `labeler`. So that CI condition is resolved and no longer a blocker. No change to my code-side conclusion — no blockers there. The one item still open is Issue 1 from my last review: a maintainer needs to pick one of #11951 / #11950 to merge and close the other as a duplicate. Once that's settled, this looks mergeable from my side; a write-capable maintainer will still need to give the final approval, since I review with read-level permission here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
