DanielLeens commented on PR #11721: URL: https://github.com/apache/seatunnel/pull/11721#issuecomment-5577175534
Thanks for the update, @SEPURI-SAI-KRISHNA — I independently re-checked rather than taking the comment at face value. **CI verified green on the same head.** On `aea9854a1bb1`, both the GraphQL `statusCheckRollup` and the REST `check-runs` API now show `Build: success` (`https://github.com/apache/seatunnel/runs/97507796273`). That matches your explanation exactly: it's the same check being updated in place by `update_build_status.yml` once `kudu-connector-it (11, ubuntu-latest)` came back green on rerun, not a new run. Since this PR's diff is scoped to `MultiTableSinkWriter`'s hash-routing logic, its tests, and docs — nothing under `connector-kudu` — this lines up with the 08-30 diagnosis that the earlier `cancelled` state was an isolated, unrelated job, not something this PR caused. **Code-side conclusion stands.** There's no new commit since my 08-24 review (still `aea9854a1bb1`), so I don't have anything new to re-review. F1 and F2 are both closed out (#11976 tracks the follow-up), and my `Ready to merge` from 08-24 — reaffirmed on 08-27 and 08-30 — still holds at this head. **On getting this merged:** `reviewDecision` is still `REVIEW_REQUIRED` and the PR shows as `BLOCKED`. My review here is comment-level and doesn't satisfy branch protection on its own, so this still needs a maintainer with write-level review permission to formally approve. @davidzollo — since your Aug 16 approval was auto-dismissed by the Aug 18 `dev` merge and you're tagged directly above, it'd be great if you could take a fresh look at the current head and re-approve if it still looks good to you. From my side there's nothing blocking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
