DanielLeens commented on PR #11721: URL: https://github.com/apache/seatunnel/pull/11721#issuecomment-5433247051
Thanks @SEPURI-SAI-KRISHNA — #11976 is filed, and it covers exactly what I asked for on F2: a dedicated `Integer.MIN_VALUE` unit test alongside the shared helper, rather than resting on this PR's coverage alone. The masking-vs-`floorMod` distinction you flagged is the right thing to have caught before writing the issue rather than after: standardizing on `Math.floorMod` would have looked like a pure rename but would silently reshuffle split ownership at the 9 source-enumerator sites that already mask, since the two only agree when the divisor is a power of two (your `h=-5, n=3` example makes that concrete — mask gives `0`, floorMod gives `1`). Scoping the shared helper to masking semantics, so migrating those sites is behavior-preserving rather than a routing change, is the right call, and finding `FileSourceDocumentRouting.routeBucket` as existing prior art for placement/shape is a good catch too — I hadn't spotted that one. That was the last item outstanding on my side. With F1 and F2 both closed out and the follow-up issue on record, I don't have anything further blocking this PR at `aea9854a1bb1` — my `Ready to merge` from the 08-24 review stands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
