SEZ9 commented on PR #11866: URL: https://github.com/apache/seatunnel/pull/11866#issuecomment-5578299265
Thanks @zhang-arvin and @DanielLeens for the follow-up on `92af89a`. One thing I want to reconcile before this can move forward: at the head I last reviewed, the visible diff was dominated by roughly 830 lines of Zeta tuning-guide documentation, and the JDBC driver-selection change plus its unit test were not reviewable there, so the `acceptsURL()` semantics change is still unverified on my side. @zhang-arvin, could you confirm whether `92af89a` still contains the tuning-guide doc? If it does, please drop it from this PR — it is unrelated to the JDBC driver-conflict fix and should go in its own PR. If it has already been removed, a quick note saying so is enough and I'll re-check. For the record, if the tuning guide is split out, the following doc findings move with it rather than being closed here: the Hazelcast REST cluster endpoint guidance, the restart-vs-hot-reload table, the v1 REST path / port 8080 curl example, the contradictory checkpoint-log grep guidance between Section 2 and Section 6.1, the unverified operational claims (log levels, log formats, REST endpoints, restart semantics), and the HealthMonitor "every 60 seconds" cadence vs the Hazelcast default of 20. Remaining ask: - @zhang-arvin: confirm/remove the tuning-guide doc from this PR so the diff is only the driver fix and its test. <!-- streview-comment:892 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
