DanielLeens commented on PR #11866: URL: https://github.com/apache/seatunnel/pull/11866#issuecomment-5578514246
@SEZ9 good to double-check, but the tuning-guide doc is confirmed gone at the head we're both discussing. I just re-pulled `pulls/11866/files` fresh against `92af89a` and it's exactly 7 files, none of them docs: - `seatunnel-connectors-v2/connector-jdbc/src/main/java/.../catalog/AbstractJdbcCatalog.java` - `seatunnel-connectors-v2/connector-jdbc/src/main/java/.../internal/connection/SimpleJdbcConnectionProvider.java` - `seatunnel-connectors-v2/connector-jdbc/src/test/java/.../catalog/AbstractJdbcCatalogTest.java` - `seatunnel-connectors-v2/connector-jdbc/src/test/java/.../catalog/ConfigurableDriver.java` (new, test double) - `seatunnel-connectors-v2/connector-jdbc/src/test/java/.../internal/connection/RejectingDriver.java` (new, test double) - `seatunnel-connectors-v2/connector-jdbc/src/test/java/.../internal/connection/SimpleJdbcConnectionProviderTest.java` (new) - `seatunnel-connectors-v2/connector-jdbc/src/test/java/.../internal/connection/ThrowingDriver.java` (new, test double) No `docs/en`/`docs/zh` path anywhere in the diff. zhang-arvin dropped the ~828-line Zeta tuning-guide bundle back on 2026-08-28, and I re-confirmed it stayed absent in every round since, including explicitly in my own `92af89a` review a couple hours before your comment (Issue 3 there: "Confirmed still absent from the current diff... This also resolves @SEZ9's Issue 1/2 from an earlier round"). So the head you're asking zhang-arvin to check is already clean — no action needed from them, this isn't a live discrepancy, just two reviews that briefly passed each other. The doc findings you listed (REST endpoint guidance, restart-vs-hot-reload table, checkpoint-log grep contradiction, HealthMonitor cadence, etc.) never need to be reopened here since that content isn't part of this PR anymore. With that reconciled, the driver-selection fix and its test coverage are what's actually in front of us, and I don't have anything to add beyond my last review (Ready to merge, no open blockers) — just gated on the fork's `Build` finishing green and a write-level maintainer merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
