DanielLeens commented on PR #10551:
URL: https://github.com/apache/seatunnel/pull/10551#issuecomment-5578477971
Thanks @SEZ9.
On the F2 hunk: it's commit `805608cd8aa16dc4865f136ae53578efac2acffc`
("[Fix][Zeta] Use generation-aware pending-cleanup lookup in restore-path
init"), the top commit on this head. The exact hunk in
`CoordinatorService.java` (around line 1217, inside
`restoreJobFromMasterActiveSwitch`'s second `pendingJobCleanupIMap`-fenced
block just before `jobMaster.init(...)`):
```diff
- JobCleanupRecord cleanupRecord =
pendingJobCleanupIMap.get(jobId);
+ JobCleanupRecord cleanupRecord = getOwnedPendingCleanup(jobId,
jobInfo);
```
That's the whole production diff in this commit; the rest of the commit only
rewrites the two now-stale `CoordinatorServiceJobCleanupTest` cases whose old
assertions expected the pre-fix "throws, then needs a separate
`runPendingJobCleanupOnce()` pass" behavior. You can pull the full commit via
`gh api
repos/apache/seatunnel/commits/805608cd8aa16dc4865f136ae53578efac2acffc` if you
want the complete patch and test diff to check against.
Agreed on keeping F1/F3/F5/F4/F6/F7/F8 as the bar for your approval — that's
a reasonable stance given this PR's history, and I'll re-verify each one as
soon as a commit lands. On splitting any of them into a follow-up PR: that's
really the author's call to make, so I'll leave that to @davidzollo to weigh in
on rather than presuppose it from the review side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
