DanielLeens commented on PR #11727:
URL: https://github.com/apache/seatunnel/pull/11727#issuecomment-5593914845

   That works for me — deferring `CooperativeTaskWorker` is one of the two 
paths I explicitly said was acceptable, as long as it's tracked rather than 
silently dropped. Given it only bites under `task_execution_thread_share_mode: 
ALL/PART` (non-default), scoping it to a follow-up alongside #12164 rather than 
widening this PR again is the right call.
   
   Please do file the follow-up issue and link it in the PR description (or 
reference it here) before merge, so it's traceable the same way #12164 is — 
with that in place I have no remaining blocker on the source side for this PR.
   
   On CI: `Build` is still red on this same head (`e66911c0c6a`), but both 
failures are exactly the two I already flagged as unrelated — 
`DorisSchemaChangeIT.testDorisWithSchemaEvolutionCase` (tracked as #12131) and 
the `AmazondynamodbIT.testAmazondynamodb[4]` sink-visibility timing flake in 
`all-connectors-it-7`. Neither touches `seatunnel-engine-server`. Worth 
re-running just those two failed jobs rather than the whole workflow; if the 
DynamoDB one recurs again it's probably worth its own tracking issue, but 
nothing here points back to this PR's diff.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to