Rangsh commented on PR #12218:
URL: https://github.com/apache/seatunnel/pull/12218#issuecomment-5629063659
@SEZ9 Thanks — the both-sides coverage point is addressed in fee6db3b3.
The PR now has a paired regression for each side of the post-publication
boundary:
1. `testDeployLocalTaskRollsBackAfterPostPublishFailureAndAllowsRedeploy`
- deterministic failure from `onContextPublished`
- asserts `executionContexts` / `cancellationFutures` are cleared
- asserts a later `deployTask` for the same `TaskGroupLocation` actually
executes
2. `testDeployLocalTaskRollsBackAfterPartialBlockingSubmitRejection`
- deterministic `RejectedExecutionException` at task submission (after
partial blocking submit)
- asserts the same map cleanup
- follow-up redeploy now also goes through `deployTask(Data)` (not
`deployLocalTask`), so it exercises the master-failover skip branch rather than
bypassing it
Local check (JDK 11): both tests pass.
Happy to take any further comments here on the PR. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
