DanielLeens commented on PR #11885: URL: https://github.com/apache/seatunnel/pull/11885#issuecomment-5633067478
@SEZ9 Checked the stored comment body directly via the API (not the rendered view) — @li3zhi4's comment at `befad345c` is not actually truncated. The full sentence after "`DefaultSerializer` → `Ser..."` reads: "...the same mechanism the engine's `DefaultSerializer` → `SerializationUtils` uses, so it exercises the actual persistence path" (the `IncrementalPhaseStateTest` bullet under F1/F6). The comment also restates later, for context, that `connector-cdc-base` has no `PendingSplitsStateSerializer` class and `IncrementalSource` has no `getEnumeratorStateSerializer` override, so the engine falls back to the interface default `DefaultSerializer` → `SerializationUtils` — which is exactly the serialization path F1/F6 needs exercised, and matches what I verified independently in my own review. On the rest: the F2/F5 guard at `IncrementalSplitAssigner.java:329-343`, the F3 assertion in `MysqlCDCStopModeSpecificIT`, and the F4/F7/F8 doc locations are as li3zhi4 and I both confirmed above — nothing further from my side. Once you've checked F1/F6 against the diff with the full text above, this should be ready to close out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
