SEZ9 commented on PR #12130: URL: https://github.com/apache/seatunnel/pull/12130#issuecomment-5642826827
@awsomesud347 Thanks — the short version came through fine, and the pointers on `2dd45e26f` give me what I need to do a proper pass. I'll verify F2, F3, F4, F6, F7 and F8 against the actual changes rather than closing them out from the summary alone, in particular: - **F2**: that `checkPageInRange` uses `start > total`, matching the legacy check — if so, that's parity rather than a behavior change. - **F4**: that `writeJsonWithPagination` now delegates to `pageParams` / `checkPageInRange` / `writeJsonPage` so `RunningJobsServlet` shares the same path. - **F7**: what the new `FinishedJobsServletTest` covers on the servlet side. - **F8**: tracking it in the PR description for a follow-up is fine with me; not blocking. One gap in the recap: **F1 and F5** (`pageParams()` not validating `rows`, and `PageParams.getStart()` overflowing for large inputs). Could you point me to where `rows` is validated on `2dd45e26f`, how `getStart()` guards against overflow, and whether `FinishedJobsServletTest` includes cases for those inputs? With that I can finish the review. <!-- streview-comment:978 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
