awsomesud347 commented on PR #12130: URL: https://github.com/apache/seatunnel/pull/12130#issuecomment-5666405561
@SEZ9 @DanielLeens has it right, and I verified every pointer against `2dd45e26f` myself before confirming: - F1: `rows` goes through `positiveIntParam` at `PageBaseServlet.java:113-114`, the same helper `page` uses at `:112`. - F5: `getStart()` at `:91-93` returns a value already validated at construction, and the overflow is caught earlier at `:119-122`, where the offset is computed as a `long` and rejected above `Integer.MAX_VALUE`. - Tests: `shouldRejectZeroRows` at `FinishedJobsServletTest.java:127-133`, `shouldRejectNegativeRows` at `:135-141`, and `shouldRejectOffsetThatOverflowsAnInt` at `:163-169`, which sends `page=Integer.MAX_VALUE, rows=10` and also asserts the service is never called. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
