DanielLeens commented on PR #11633: URL: https://github.com/apache/seatunnel/pull/11633#issuecomment-5649656554
This closes out the procedural item from my last review. Thank you for going the extra mile and pulling the actual stack trace instead of just asserting "it's flaky" — `ConditionTimeoutException` on `SplitClusterFaultToleranceIT.testStreamJobCancelResolvesWhenWorkerCrashesBeforeCancelAck` waiting on a worker-crash-during-cancel timing window is exactly the shape of test I'd expect to be environment-sensitive rather than something a JSON-deserializer default-value change could cause, and the fact that the same job families (`engine-v2-it`, `all-connectors-it-2/6/7`, `paimon-connector-it`) are also red on `dev`'s own latest run makes the "pre-existing, not PR-caused" case solid. Good catch on `doris-connector-it` and `transform-v2-it-part-2` clearing after the resync too — that confirms the remaining reds aren't a stale-branch artifact either. No code-level blocker remains from my side, and I no longer have an open CI question either. This is Ready to merge from my perspective, pending a maintainer's final look. Nice work carrying this through several review rounds with this level of rigor — this is exactly the kind of evidence-based back-and-forth that makes a review productive instead of just a waiting game. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
