Nikk8091 opened a new pull request, #12315:
URL: https://github.com/apache/seatunnel/pull/12315

   ### Purpose of this pull request
   
   This PR handles the `connector-sensorsdata` sink slice of #11007.
   
   It registers `server_url` as a required option with a declarative nonblank 
constraint and registers `consumer` as an optional option. The existing 
`consumer = batch` default and the existing batch/console runtime behavior are 
unchanged. No SDK, format, network, timeout, retry, or runtime validation is 
added.
   
   The existing English and Chinese connector documentation already describes 
`server_url` as required and `consumer` as optional with the `batch` default.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. Missing, empty, and whitespace-only `server_url` values are now 
rejected during factory configuration validation. Existing nonblank URLs and 
both `batch` and `console` consumer configurations remain valid.
   
   ### How was this patch tested?
   
   Added focused `SensorsDataSDKFactoryTest` coverage for:
   
   - valid `batch` and `console` configurations;
   - missing `server_url`;
   - empty `server_url`;
   - whitespace-only `server_url`;
   - omitted `consumer`, confirming it still defaults to `batch`.
   
   Validation results:
   
   - `./mvnw spotless:apply` — passed.
   - `./mvnw -pl seatunnel-connectors-v2/connector-sensorsdata -DskipITs 
verify` — passed (13 tests, 0 failures, 0 errors).
   - `git diff --check` — passed.
   - `./mvnw -q -DskipTests verify` — attempted; it reached 
`connector-jdbc-e2e-part-2` and stopped on a Maven Central connection reset 
while resolving `error_prone_annotations:2.38.0`. No SensorsData failure was 
reported.
   
   ### Check list
   
   * [x] No new Jar binary package is added.
   * [x] Existing English and Chinese SensorsData documentation already matches 
this validation contract.
   * [x] No incompatible configuration name, default, or runtime behavior is 
introduced.
   * [x] No connector registration, distribution, label, E2E, or plugin 
configuration changes are required because this updates validation for an 
existing connector only.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to