SEZ9 commented on PR #11545:
URL: https://github.com/apache/seatunnel/pull/11545#issuecomment-6009378629
Thanks for the correction and for tracking down the `connector-lance`
failure in run 37317968844 — the `<argLine>${surefire.jvm.args}</argLine>`
override in that module's pom explains why removing the repeated flags in
`4ce5edfba` surfaced the `java.nio.Buffer.address`
`InaccessibleObjectException`, and restoring them in `c284df271` is the right
short-term fix.
On F6/F8, here is where I think this leaves us:
- With the flags repeated in both unit-test steps again, the unit-test lane
no longer demonstrates that `surefire.module.args` is sufficient on its own;
only the integration-test lanes (which pass no `-Dsurefire.jvm.args`) exercise
the pom property. That is acceptable for this PR, but please state it
explicitly in the PR description and in the step comments so nobody later
re-removes the flags assuming they are redundant.
- Agreed that making `connector-lance/pom.xml` inherit
`surefire.module.args` should be a separate change. Please open that follow-up
(or at least file an issue) so the duplication has an owner and a path to
removal.
- Please confirm whether the workflow-level `JAVA_TOOL_OPTIONS` in
`backend.yml` is still present on `d1794e8fb`, or whether the module flags are
now scoped only to the steps that need them. If it is still global, the F6
concern (CI never running on a plain JDK 11/17) and the F8 stderr noise remain
open, and I would like to see it narrowed to the specific steps.
Remaining asks:
1. Report the `unit-test (17)` result from run 37331927562 (ubuntu and
windows) once it finishes.
2. Update the PR description / step comments as noted above.
3. Clarify the current state of the global `JAVA_TOOL_OPTIONS` and, if still
global, scope it down.
For the unrelated reds (`all-connectors-it-2 (11)` HTTP 429 on the Maven
Wrapper download, `edge-agent-it (11)` node start timeout), a green rerun is
enough; no action needed in this PR.
<!-- streview-comment:1557 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
