CryoThrust commented on PR #12152: URL: https://github.com/apache/seatunnel/pull/12152#issuecomment-5770576882
@SEZ9 The test method names covering F1 and F2 in `CheckpointCoordinatorTest.java` (rebased onto latest `dev` at `0a4b61553`, cleanly with 0 conflicts and spotless passing) are: 1. **F2(a) Delivery assertion:** `testCheckpointErrorReportDoesNotRunOnCallerThread` (lines 1028-1056). It releases the busy executor via `releaseExecutor.countDown()` and asserts `Mockito.verify(checkpointManager, Mockito.timeout(5000)).handleCheckpointError(Mockito.eq(1), Mockito.eq(false))` so the report is verified delivered and handled once unblocked. 2. **F1 / F2(b) Rejection un-parks caller:** `testCheckpointErrorReportCompletesFutureWhenExecutorRejects` (lines 1066-1077). Builds the coordinator with an already-`shutdownNow()`-ed primary executor, triggers the error, and asserts `waitCheckpointCoordinatorComplete().get(5, TimeUnit.SECONDS)` un-parks and returns. 3. **F1 / F2(b) Rejection reaches cancellation off operation thread:** `testCheckpointErrorReportRejectionStillReachesCancellationOffCallerThread` (lines 1084-1110). Also uses a shut-down primary executor, verifies `handleCheckpointError(1, false)` still runs on the fallback executor, and asserts `callerThread != handlerThread`. `CheckpointCoordinatorTest`: 19 run, 0 failures. Spotless clean. Fresh CI run triggered on `0a4b61553`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
