SEZ9 commented on PR #12152: URL: https://github.com/apache/seatunnel/pull/12152#issuecomment-6009390136
Thanks @CryoThrust for syncing onto `dev` at `eb2eb1ddc` — good to hear the rebase was clean and that `CheckpointCoordinatorTest` and `spotless:check` pass locally on `0d31cf999`. From the code side there is nothing further blocking on the two earlier findings: - **F1 (rejected / shut-down executor):** the guarded `execute()` with the fallback-dispatch-then-complete ordering means a `RejectedExecutionException` no longer drops the task-reported error or leaves a `.join()`/`.get()` waiter parked, and the `isDone()` guard stays meaningful. - **F2 (test coverage):** `testCheckpointErrorReportDoesNotRunOnCallerThread` now positively asserts delivery once the busy executor is released, and `testCheckpointErrorReportCompletesFutureWhenExecutorRejects` / `testCheckpointErrorReportRejectionStillReachesCancellationOffCallerThread` cover the `shutdownNow()`-ed primary executor path. The one remaining item is CI. The last `Build` result I have is the `FAILURE` on `0a4b61553` (fork run `35681392273`), where the failures were unrelated to this change. Could you ping here once the fresh run on `0d31cf999` has completed? If it comes back clean — or with failures we can again confirm are unrelated — I'll approve. <!-- streview-comment:1558 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
