SEZ9 commented on PR #12152: URL: https://github.com/apache/seatunnel/pull/12152#issuecomment-5826050071
Thanks @CryoThrust — the mapping you posted lines up with the two open findings: - **F2(a)**: `testCheckpointErrorReportDoesNotRunOnCallerThread` releasing the busy executor via `releaseExecutor.countDown()` and verifying `handleCheckpointError(1, false)` with `Mockito.timeout(5000)` is exactly the delivery assertion that was missing. - **F1 / F2(b)**: `testCheckpointErrorReportCompletesFutureWhenExecutorRejects` and `testCheckpointErrorReportRejectionStillReachesCancellationOffCallerThread`, both driven from an already-`shutdownNow()`-ed primary executor, cover the rejection path (future un-parks, and the handler still runs off the caller thread). I'll confirm those test bodies and the fallback dispatch against the diff at `0a4b61553` and then mark F1/F2 resolved. Nothing further needed from you at this point. <!-- streview-comment:1312 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
