SEPURI-SAI-KRISHNA opened a new pull request, #12438: URL: https://github.com/apache/seatunnel/pull/12438
### Purpose of this pull request Two comments in the RocketMQ connector no longer describe the code around them. Both are mine, and both went stale when the PRs they referenced merged. This corrects them and changes nothing else. **1. `RocketMqAdminUtil.currentOffsets` overstates its own invariant.** The comment at the `TOPIC_NOT_EXIST` early return says the accumulated map "is necessarily still empty here". @DanielLeens flagged on #12417 that the invariant does not establish that, and he is right. Each loop iteration calls `examineConsumeStats` again, which re-resolves the group's retry topic. A retry topic that resolved on an earlier iteration and has gone by a later one would reach this return with offsets already collected for the earlier topics. The rewritten comment keeps the invariant and the existing guidance that the `return` has to become a `continue` if that ever becomes reachable, and names the transition it does not cover instead of claiming there is none. **2. `RocketMqIT` describes #12349 as unmerged.** The comment reads: > On dev `currentOffsets` still maps a failed lookup onto an empty map, so today this is a consistency fix; it becomes load bearing once #12349 makes that call raise `RocketMqConnectorException` #12349 merged on 2026-09-21. Both halves are now false: `currentOffsets` already raises, and the retry predicate is already load bearing rather than a consistency fix. Rewritten in the present tense. ### Does this PR introduce _any_ user-facing change? No. Comments only. Both files are byte-identical to `dev` once `//` comments and blank lines are stripped: ``` diff -B <(strip dev/RocketMqAdminUtil.java) <(strip RocketMqAdminUtil.java) # empty diff -B <(strip dev/RocketMqIT.java) <(strip RocketMqIT.java) # empty ``` ### How was this patch tested? ``` ./mvnw -pl seatunnel-connectors-v2/connector-rocketmq test Tests run: 24, Failures: 0, Errors: 0, Skipped: 0 ``` `spotless:check` is green, and `connector-rocketmq-e2e` test-compiles. The container-backed `RocketMqIT` was not run locally, since Docker is not available in my environment, but the change to that file is a comment. ### Note on overlapping work #12350 also touches `RocketMqIT.java`. Its hunks run from line 487 to 651 and do not include the comment changed here, so there is no textual overlap. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
