SEZ9 commented on PR #12438: URL: https://github.com/apache/seatunnel/pull/12438#issuecomment-5923276975
Thanks for re-posting the clipped paragraph in full, @SEPURI-SAI-KRISHNA, and for the update that the head is still `5cc724b9342` with the same blobs (`03ecf079` for `RocketMqAdminUtil.java`, `7fc989a0` for `RocketMqIT.java`) and that attempt 2 of run `36437331456` was a rerun of that commit rather than a new push. On the two findings, the wording you quoted is the direction I was asking for: - **PR12438-F1** – asserting that the transition is reachable and naming the full-rewind consequence at `RocketMqAdminUtil.java:349-359` is exactly what the earlier comment was missing. - **PR12438-F2** – dropping the PR-number anchor and the past-tense narration at `RocketMqIT.java:535-540`, and separating the exception case from the legitimately-empty-map case, addresses the imprecision I flagged. Noted on the pre-existing "previously had" comment being unchanged from `dev` and outside this diff; I am not asking you to touch it here. I still need to read both passages at `5cc724b9342` myself before closing either finding, so I will hold off on marking them resolved until I have done that read-through and will follow up here with the result. <!-- streview-comment:1432 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
