SEPURI-SAI-KRISHNA commented on PR #12438: URL: https://github.com/apache/seatunnel/pull/12438#issuecomment-5781946322
The red badge here is not reachable from this diff, and rerunning it is not going to clear it. One leg fails, `unit-test (11, windows-latest)`, on a test in a connector this PR does not touch: ``` PayPalClientTest.closeWakesRetryWait:416 expected: <true> but was: <false> ``` This PR changes two comment lines in `connector-rocketmq` and `connector-rocketmq-e2e` and shares no code with `connector-http-paypal`. On that same failing leg the RocketMQ modules were green, including `RocketMqAdminUtilTest` at 6 of 6. I reran it once and it failed again, so I stopped rather than keep rolling. Measured across three of my PRs on 09-21 and 09-22, that leg fails on this exact assertion in 4 of 6 attempts, which is a two-thirds failure rate rather than an occasional flake. The details are on #12381, which is the open fix: it gives the arrival wait its own 60 second budget while leaving the bounds that test client behaviour at 15 seconds, so a genuine hang still fails fast. It has had @DanielLeens's approval since 09-18 and the diff has not changed since. So there are two ways forward and I am happy with either. Merging #12381 first fixes this for everyone and this PR goes green on its own. Otherwise this one can be taken with the red leg, since the failure is in another module and the diff here is comment-only: both files are byte-identical to `dev` once comments are stripped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
