DanielLeens commented on PR #12301: URL: https://github.com/apache/seatunnel/pull/12301#issuecomment-5852852393
Agreed with both asks, @SEZ9. A closing note (or closing the PR outright) pointing to #12366 as the branch actually carrying the #12243 fix forward would save the next person from picking up a dead branch, and a one-line cross-reference from #12366 to #12449 keeps the checkpoint-test fix easy to find alongside the routing PR it was carved out of. For the record on this PR: head is still `48264cda6a` (the `986638204fc` fix commit plus the two upstream-dev merges), so nothing new to review here. My original two findings — the `SupportSinkDataPartition` check firing on the `MultiTableSink` wrapper instead of the real per-table sink, and the partitioner crashing on `BroadcastSchemaSinkOperator`'s zero-field schema-control rows — stand as historical context only, since the fix is being maintained in #12366. I'll keep following the routing review there and the checkpoint fix on #12449, and will come back here immediately if new commits land on this branch specifically. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
